-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added textCommand #181
base: master
Are you sure you want to change the base?
Added textCommand #181
Conversation
Support for textCommand added following the approach from https://github.com/thorsten-gehrig/alexa-remote-control/blob/master/alexa_remote_control.sh
Support for textCommand added following the approach from https://github.com/thorsten-gehrig/alexa-remote-control/blob/master/alexa_remote_control.sh
More changes related to textCommand extension
More changes related to textCommand extension
More changes related to textCommand extension
textCommand support
Details added
Hey, thanks for continuing to develop the Node! |
Hi! It would be good, but as far as I can tell none of the other commands from alexa-remote-routine.js is implemented using alexa-remote. Wouldn't switching everything require an almost complete rewrite of alexa-remote-routine.js? Or did I misunderstand your suggestion? Best, |
Hi Marcello! The dependency alexa-remote is used after all. Best regards, |
Maybe it’s time to fork this repo. And update https://github.com/Apollon77/alexa-remote dependency |
Hi @mbalduccini. I have forked this node (https://github.com/bbindreiter/node-red-contrib-alexa-remote2-applestrudel) and would like to incorporate your PR. Can you rebase and create a PR in my repo? If not, are you ok with me adding your code (with full attribution of course)? Thanks |
If you'd like to point me to the steps needed for rebasing and creating a PR in your repo, I'll be happy to do it. Otherwise, it's also ok with me if you go ahead and add my code. |
Thanks @mbalduccini. I've added your code changes here: bbindreiter@ab48b11 |
Added textCommand -- see https://github.com/thorsten-gehrig/alexa-remote-control. Version bumped to 3.10.5.